Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] V2 - Saved Articles slide #5098

Merged
merged 26 commits into from
Dec 5, 2024
Merged

[YiR] V2 - Saved Articles slide #5098

merged 26 commits into from
Dec 5, 2024

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Nov 28, 2024

Phabricator: https://phabricator.wikimedia.org/T376067

Notes

  • Adds the saved count slide for eligible users (logged-in users with more than 3 saved articles)
  • Shows collective slide for the rest of users
  • Saved count and the random saved article titles are retrieved from the main app core data and passed through an async call, using a delegate
  • These new core data methods live in MWKSavedPageList
  • Copy and assets are still outdated, no V2 updates were made

Test Steps

  1. Logged in, device set to Italy or Mexico, set main language to en, es or it
  2. Browse 7+ articles
  3. Background the app
  4. You should see the personalized saved article slide if you have more than 3 saved articles, plus the names of 3 random articles you saved
  5. Remove saved article, leave 2 or less
  6. Trigger the regeneration of the report (you can disable and re-enable the YiR repot in settings)
  7. You should now see the collective slide
  8. Logged out, in a device with any number of saved slides - you should always see the collective slide

@mazevedofs mazevedofs marked this pull request as draft November 28, 2024 14:45
@mazevedofs
Copy link
Collaborator Author

Opening as a draft so I can get feedback on some issues I'm having

@mazevedofs mazevedofs marked this pull request as ready for review December 3, 2024 17:25
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little things from code review. I will push these PR feedback tweaks.

@tonisevener tonisevener merged commit 71ce7a8 into main Dec 5, 2024
4 checks passed
@tonisevener tonisevener deleted the yir-saved-slide branch December 5, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants