[YiR] Only populate after login if app has resumed #5083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T378135
Notes
This fixes a console complaint I started to notice today:
I think this is caused by my additional call to populate YiR report data after the user logs in (added in #5074). When an app launches, it makes the
populateYearInReviewReport
method call twice fairly quickly: Once fromperformTasksThatShouldOccurAfterBecomeActiveAndResume
after the app finishes its launch setup code, and again fromuserWasLoggedIn
. I think something about this is causing merge conflicts on Core Data (the initial report without editing data attempts to save at the same time as the next report with editing data).To get around this, I am only calling
populateYearInReviewReport
withinuserWasLoggedIn
if the app has already completed its setup.Test Steps