Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Prompt user to log in after survey #5068

Merged
merged 9 commits into from
Nov 19, 2024
Merged

[YiR] Prompt user to log in after survey #5068

merged 9 commits into from
Nov 19, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376350

Notes

This PR presents an alert view to prompt the user to log in after dismissing the survey. It navigates to the login flow using our existing LoginCoordinator.

Note: I am trying to reuse very similar existing strings we had for the button titles, so the copy doesn't exactly match the Figma. I will run this through design review.

Since this task was a nice-to-have for V1, I am doing the specific translations and metrics separately. This way we don't have to consider it as we wrap up T376666 and T376302.

Test Steps

  1. Fresh install app. Ensure primary app language is target wiki. Take steps to ensure entry point appears while logged out (build up article history, go to Settings, disable YiR, then enable YiR, background/foreground).
  2. Go through year in review feature. After dismissing survey after the last slide, login prompt should appear.

@tonisevener tonisevener requested review from a team and l-olson1214 and removed request for a team November 13, 2024 20:26
@tonisevener tonisevener merged commit 449b0c4 into main Nov 19, 2024
4 checks passed
@tonisevener tonisevener deleted the T376350 branch November 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants