Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T378507 UI fixes #5064

Merged
merged 3 commits into from
Nov 11, 2024
Merged

T378507 UI fixes #5064

merged 3 commits into from
Nov 11, 2024

Conversation

l-olson1214
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T378507#10301445

Notes

  • Added icon in intro slide
  • Updated toolbar appearance to avoid pull down color issue

Test Steps

  1. In English, Spanish, or Italian in Italy or Mexico in scheme
  2. Open app, log in if not logged in
  3. Enable year in review feature flag in developer settings
  4. Navigate through 6+ articles, background and foreground app.
  5. Navigate to Year in Review
  6. Ensure icon is in intro slide.
  7. Navigate to one of the other slides, and try a pull down as far as possible, ensure background of bottom toolbar remains the proper color.
  8. Repeat with other background options.

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-11-08.at.15.54.54.mp4

@l-olson1214 l-olson1214 requested review from a team and tonisevener and removed request for a team November 8, 2024 20:56
mazevedofs
mazevedofs approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mazevedofs mazevedofs merged commit 46e35d9 into main Nov 11, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T378507-ui-fixes branch November 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs mazevedofs approved these changes

@tonisevener tonisevener Awaiting requested review from tonisevener tonisevener was automatically assigned from wikimedia/ios

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-olson1214 @mazevedofs