Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: N/A
Notes
This PR fixes a race condition that I think only appeared once #5044 and #5056 were merged.
I noticed that ExploreViewController's lazy yirCoordinator was stuck with nil, because it's
yirDataController
would throw acoreDataStoreUnavailable
error upon instantiation. Likely when a YearInReviewDataController is instantiated early on in the app lifecycle, the core data store isn't ready yet. Adjusting these a bit to make theyirDataController
computed on Explore and Article (so that it tries again each time), and relaxing the laziness a bit foryirCoordinator
, seems to help.Test Steps