Update number formatting #5055
Merged
Update number formatting #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-olson1214
requested review from
a team and
tonisevener
and removed request for
a team
Base slide subtitle 1 is for testing without function to see if function is breaking
# Conflicts: # Wikipedia/iOS Native Localizations/pa.lproj/Localizable.strings
tonisevener
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Looks great.
While we're here adjusting translations, I went ahead and pushed a commit tweaking the numbers for T378515. These should now match the latest Figma numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T378508
Notes
Test Steps
Screenshots/Videos