Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YiR] Update share slide #5053

Merged
merged 9 commits into from
Nov 7, 2024
Merged

[YiR] Update share slide #5053

merged 9 commits into from
Nov 7, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376300

Notes

  • Updates the UI to use the new design
  • Updates the share sheet to show the app icon
  • Fixes W icon theming on the slides

Test Steps

  1. On a slide, tap share
  2. Verify the new design on the shared slides (colorful images and W on top)
  3. Verify the W icon on the share sheet. The text will no longer preview

tonisevener
tonisevener approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@tonisevener tonisevener merged commit c998716 into main Nov 7, 2024
4 checks passed
@tonisevener tonisevener deleted the update-share branch November 7, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @tonisevener