Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T378019 yir landscape #5049

Merged
merged 7 commits into from
Nov 6, 2024
Merged

T378019 yir landscape #5049

merged 7 commits into from
Nov 6, 2024

Conversation

l-olson1214
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T378019

Notes

  • Locks the YIR into

Test Steps

  1. Open app normally, but in one of the targeted regions/languages in order to show Year in Review.
  2. Ensure you have at least 6+ articles in history, background and foreground the app.
  3. Navigate to any article, test to ensure landscape mode works.
  4. Return to portrait mode.
  5. Navigate to Year in Review, try landscape mode.
  6. Ensure it doesn't work.
  7. Navigate OUT of Year in Review, ensure you are able to get portrait and landscape.

Screenshots/Videos

@l-olson1214 l-olson1214 requested review from a team and tonisevener and removed request for a team November 4, 2024 21:15
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tonisevener tonisevener merged commit b07b1a1 into main Nov 6, 2024
2 of 4 checks passed
@tonisevener tonisevener deleted the T378019-yir-landscape branch November 6, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants