[YiR] Donate slide (Part 1 - data) #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested review from
a team and
l-olson1214
and removed request for
a team
l-olson1214
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T378838
Notes
This PR checks for our new
donateCountconfig key and populates a donate slide in the YiR report. This is pre-work to determine if we should add the personalized or collective donate slide. It is patterned after the read count slide logic.Test Steps
This is not really testable until the UI layer is in, but if you want, you could submit a donation before enabling the YiR developer settings toggle. Background, foreground to trigger report creation. Then when tapping the profile button, add a breakpoint here to confirm that the donate personalized slide display property == true.