Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T378491: Update Slides #5040

Merged
merged 12 commits into from
Oct 31, 2024
Merged

T378491: Update Slides #5040

merged 12 commits into from
Oct 31, 2024

Conversation

l-olson1214
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T378491

Notes

  • Numbers may be wrong, they will be updated before launch

Test Steps

  1. Navigate to YIR (usual set up to enable)
  2. Scroll through slides, ensure each one has a gradient, and the proper item associated with it (image vs text)

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-10-30.at.14.38.15.mp4

@l-olson1214 l-olson1214 requested review from a team and mazevedofs and removed request for a team October 30, 2024 18:41
golson-wmf added 4 commits October 30, 2024 15:20
# Conflicts:
#	Wikipedia/Code/YearInReviewCoordinator.swift
#	Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! You can delete the old YiR illustrations since we won't need it.

golson-wmf added 2 commits October 31, 2024 16:25
# Conflicts:
#	Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
@mazevedofs mazevedofs merged commit 01c31e1 into main Oct 31, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T378491-update-slides branch October 31, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants