-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T378491: Update Slides #5040
Merged
Merged
T378491: Update Slides #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-olson1214
requested review from
a team and
mazevedofs
and removed request for
a team
October 30, 2024 18:41
l-olson1214
force-pushed
the
T378491-update-slides
branch
from
October 30, 2024 18:44
056f6e7
to
249ed2e
Compare
l-olson1214
force-pushed
the
T378491-update-slides
branch
from
October 30, 2024 18:45
249ed2e
to
d932c29
Compare
l-olson1214
force-pushed
the
T378491-update-slides
branch
from
October 30, 2024 18:56
dfd8c8e
to
fd8399a
Compare
# Conflicts: # Wikipedia/Code/YearInReviewCoordinator.swift # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
mazevedofs
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! You can delete the old YiR illustrations since we won't need it.
# Conflicts: # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
mazevedofs
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T378491
Notes
Test Steps
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-10-30.at.14.38.15.mp4