Fixed typos in file paths breaking compilation on case-sensitive file systems #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tladesignz Thanks for the fix! I have created an associated Phabricator task so that we can track it's status on our workboard - https://phabricator.wikimedia.org/T377345. We will post feedback here in GitHub if any changes are needed from code review. |
|
@tladesignz Thanks for the PR. Can you provide test steps for us? I can spin up a case-sensitive volume on my machine and compile from there, but I wanted to make sure that matches your setup. |
|
To reproduce:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.