Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - Go to article preview #4804

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Image recommendations - Go to article preview #4804

merged 4 commits into from
Apr 3, 2024

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Apr 2, 2024 •
edited
Loading

Phabricator: https://phabricator.wikimedia.org/T358920

Notes

Test Steps

  1. Run the experimental app
  2. Tap the Image Recommendation card
  3. Tap "Yes" for a recommendation
  4. On the Add Image Details view, add some caption and tap next
  5. You should preview the first section of the article with the image and caption
  6. Go to the page editor, add an image and preview the edit, make sure nothing breaks or looks off

@mazevedofs mazevedofs added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Apr 2, 2024
@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team April 2, 2024 17:32
Base automatically changed from image-recs-data-to-preview to main April 2, 2024 21:23
@tonisevener tonisevener removed the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Apr 2, 2024
@tonisevener tonisevener self-assigned this Apr 2, 2024
tonisevener
tonisevener reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple of things that jumped out at me. Happy to merge as-is if you want to work on those in later PRs.

...nents/Components/Suggested Edits/Image Recommendations/WKImageRecommendationsViewModel.swift Outdated Show resolved Hide resolved
Wikipedia/Code/InsertMediaSettingsViewController.swift Show resolved Hide resolved
@tonisevener tonisevener removed their assignment Apr 2, 2024
@tonisevener tonisevener merged commit dbda0ee into main Apr 3, 2024
4 checks passed
@tonisevener tonisevener deleted the image-recs-article-preview branch April 3, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @tonisevener