Image Recommendations - Fetch images in WKData #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a perform method that supports returning Data - Move bodyContentType to basic service (was unused by MediaWikiService) - Add AcceptType enum to specify header value from data controller
tonisevener
requested review from
a team and
mazevedofs
and removed request for
a team
staykids
reviewed
Apr 1, 2024
...nents/Components/Suggested Edits/Image Recommendations/WKImageRecommendationsViewModel.swift
Outdated
Show resolved
Hide resolved
...nents/Components/Suggested Edits/Image Recommendations/WKImageRecommendationsViewModel.swift
Outdated
Show resolved
Hide resolved
WKData/Sources/WKData/Data Controllers/Shared/WKImageDataController.swift
Outdated
Show resolved
Hide resolved
WKData/Sources/WKData/Data Controllers/Shared/WKImageDataController.swift
Outdated
Show resolved
Hide resolved
|
@staykids Agreed on all of those, thanks. This is ready for another review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T358933
Notes
This PR adds the ability to fetch images from WKData, and integrates it into Image Recommendations.
Test Steps