Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit summary updates #4794

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Edit summary updates #4794

merged 13 commits into from
Mar 28, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T354219

Notes

Applies the following adjustments to improve edit summary:

  • Change Publish button gray color if edit summary textfield is empty
  • Moves edit summary "Learn more" button down to match Figma
  • Shows watchlist toggle, turns ON if article is already on user's watchlist
  • Adjusts font sizes on edit summary view
  • Adds "Empty edit summary" copy to article history and watchlist cells if there is no edit summary

Test Steps

Go over bullet points above, confirm code is working as expected.

@tonisevener tonisevener requested review from a team and staykids and removed request for a team March 26, 2024 16:42
@tonisevener tonisevener marked this pull request as draft March 26, 2024 16:42
@tonisevener tonisevener marked this pull request as ready for review March 26, 2024 16:46
@staykids staykids assigned staykids and unassigned staykids Mar 27, 2024
staykids
staykids approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@staykids staykids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't encounter a watched item with an empty summary to test that. Will leave one note on the Phab ticket about a nice to have change related to watching an item after publish.

@staykids staykids merged commit d4648c0 into main Mar 28, 2024
4 checks passed
@staykids staykids deleted the edit-summary-updates branch March 28, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staykids staykids staykids approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonisevener @staykids