Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - Push to commons after tapping image link #4791

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Image recommendations - Push to commons after tapping image link #4791

merged 5 commits into from
Mar 29, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T358913

Notes

This PR pushes to the commons URL in a web view after tapping the image link in the bottom sheet.

Test Steps

  1. Open image recommendations, tap image link.
  2. Confirm commons page is pushed on in a web view.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team March 25, 2024 16:19
@staykids staykids self-assigned this Mar 29, 2024
@staykids staykids merged commit f4b4720 into main Mar 29, 2024
4 checks passed
@staykids staykids deleted the T358913 branch March 29, 2024 20:35
@staykids staykids removed their assignment Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staykids staykids staykids approved these changes

@mazevedofs mazevedofs Awaiting requested review from mazevedofs mazevedofs was automatically assigned from wikimedia/ios

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonisevener @staykids