-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image recommendations: Add survey view #4787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of minor things you can remove. Also, if there's a quick modifier you could add somewhere to avoid this iPad split view, I think that would be good to fit in here.
Larger iPad improvements will be handled separately in https://phabricator.wikimedia.org/T360036.
...mponents/Suggested Edits/Image Recommendations/Survey/WKImageRecommendationsSurveyView.swift
Outdated
Show resolved
Hide resolved
...mponents/Suggested Edits/Image Recommendations/Survey/WKImageRecommendationsSurveyView.swift
Outdated
Show resolved
Hide resolved
@tonisevener Apologies – removed that unused WIP code that slipped in before design review. Also updated the navigation view presentation style so it doesn't appear in that sidebar style on iPad. |
Phabricator: https://phabricator.wikimedia.org/T358924
Notes
Adds survey view presented to user when they tap "No" to indicate that they don't recommend the suggestion. This has been design reviewed, but includes requested design changes that have not yet been re-reviewed and confirmed.
Test Steps