Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image recommendations: Add survey view #4787

Merged
merged 19 commits into from
Mar 28, 2024
Merged

Image recommendations: Add survey view #4787

merged 19 commits into from
Mar 28, 2024

Conversation

staykids
Copy link
Contributor

@staykids staykids commented Mar 22, 2024

Phabricator: https://phabricator.wikimedia.org/T358924

Notes

Adds survey view presented to user when they tap "No" to indicate that they don't recommend the suggestion. This has been design reviewed, but includes requested design changes that have not yet been re-reviewed and confirmed.

Test Steps

  1. Open Suggested edits view
  2. Tap "No" on bottom modal sheet suggestion
  3. Confirm Survey view is displayed
  4. Submit button should be disabled until the user selects an option
  5. Confirm typing in the other field enables the checkmark for that field, and tapping a different reason while the field is active resigns the responder status for the textfield and dismisses the keyboard
  6. Optionally, you can inspect the submit button's action to confirm the user selected reasons are computed properly when the user taps submit

@staykids staykids marked this pull request as ready for review March 27, 2024 19:38
@staykids staykids requested review from a team and tonisevener and removed request for a team March 27, 2024 19:38
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of minor things you can remove. Also, if there's a quick modifier you could add somewhere to avoid this iPad split view, I think that would be good to fit in here.

test

Larger iPad improvements will be handled separately in https://phabricator.wikimedia.org/T360036.

@staykids
Copy link
Contributor Author

@tonisevener Apologies – removed that unused WIP code that slipped in before design review. Also updated the navigation view presentation style so it doesn't appear in that sidebar style on iPad.

@tonisevener tonisevener merged commit ce0cdda into main Mar 28, 2024
4 checks passed
@tonisevener tonisevener deleted the T358924/survey branch March 28, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants