Merge pull request #5069 from wikimedia/fix-tests

Specify language and region for test plans, remove from schemes
wikimedia · Nov 13, 2024 · 0585b13 · 0585b13
2 parents 61039a5 + 90d7109
commit 0585b13
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/Test Plans/UITests.xctestplan b/Test Plans/UITests.xctestplan
@@ -20,7 +20,8 @@
             "argument" : "UITestThemeSepia"
           }
         ],
-        "language" : "he"
+        "language" : "he",
+        "region" : "IL"
       }
     },
     {
@@ -32,7 +33,8 @@
             "argument" : "UITestThemeDark"
           }
         ],
-        "language" : "de"
+        "language" : "de",
+        "region" : "DE"
       }
     },
     {
@@ -44,11 +46,14 @@
             "argument" : "UITestThemeBlack"
           }
         ],
-        "language" : "vi"
+        "language" : "vi",
+        "region" : "VN"
       }
     }
   ],
   "defaultOptions" : {
+    "language" : "en",
+    "region" : "US",
     "testTimeoutsEnabled" : true,
     "userAttachmentLifetime" : "keepAlways"
   },

diff --git a/Test Plans/WMFComponents.xctestplan b/Test Plans/WMFComponents.xctestplan
@@ -9,6 +9,8 @@
     }
   ],
   "defaultOptions" : {
+    "language" : "en",
+    "region" : "US",
     "testTimeoutsEnabled" : true
   },
   "testTargets" : [

diff --git a/Test Plans/WMFData.xctestplan b/Test Plans/WMFData.xctestplan
@@ -4,17 +4,20 @@
       "id" : "BAD75B0C-AB52-4988-86B4-ECD18DA1424E",
       "name" : "Configuration 1",
       "options" : {
-
+        "language" : "it",
+        "region" : "IT"
       }
     }
   ],
   "defaultOptions" : {
+    "language" : "en",
+    "region" : "US",
     "testTimeoutsEnabled" : true
   },
   "testTargets" : [
     {
       "target" : {
-        "containerPath" : "container:..\/WMFData",
+        "containerPath" : "container:",
         "identifier" : "WMFDataTests",
         "name" : "WMFDataTests"
       }

diff --git a/Test Plans/Wikipedia.xctestplan b/Test Plans/Wikipedia.xctestplan
@@ -17,6 +17,8 @@
         "value" : "1"
       }
     ],
+    "language" : "en",
+    "region" : "US",
     "targetForVariableExpansion" : {
       "containerPath" : "container:Wikipedia.xcodeproj",
       "identifier" : "D4991434181D51DE00E6073C",

diff --git a/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme b/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
@@ -97,7 +97,6 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       disablePerformanceAntipatternChecker = "YES"
-      language = "en"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"