-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chunking for API requests #87
base: master
Are you sure you want to change the base?
Conversation
Sadly, Wikimedia is still on ES6 as part of the compatibility policy, and because the gadget minifier is a dinosaur. Async/await is not supported. Can this patch please be refactored to remove await? |
Remove dependancy on await
Sure, done. |
It seems my patch would incidentally fix another, very similar bug: |
Minor linting fixes
Oops, didn't realise the linter was that strict. I've fixed that as well. |
@NovemLinguae , any chance of this being reviewed? |
I'd have to get it running on testwiki, test it, then deploy it. Will see if I can make some time for that. Gotta refresh my memory, it's been awhile! |
Looks hard to test too. Maybe I'll edit the code to have the chunks only be 2 big instead of 50 during the test. Then I can set up like 3 or 5 categories or something to test. |
Okay, thanks for taking the time for this. |
Fixes #60, hopefully.