Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Standard #15

Merged
merged 36 commits into from
Jan 3, 2019
Merged

.Net Standard #15

merged 36 commits into from
Jan 3, 2019

Conversation

tpluscode
Copy link
Contributor

@tpluscode tpluscode commented Aug 19, 2018

fixes #11

Bringing .NET Standard support:

  • .NET Standard 1.5 and .NET Framework 4.5.2

To do:

  • fix unit tests
  • rework code coverage
  • update style cop to analysers
  • fix Costura
  • ensure SpecFlow works
  • nuget packaging
  • gitlink

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@753ba07). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #15   +/-   ##
========================================
  Coverage          ?   88.1%           
========================================
  Files             ?      32           
  Lines             ?     656           
  Branches          ?      58           
========================================
  Hits              ?     578           
  Misses            ?      67           
  Partials          ?      11
Impacted Files Coverage Δ
.../JsonLD.Entities/Converters/JsonLdListConverter.cs 65% <ø> (ø)
...JsonLD.Entities/Converters/JsonLdArrayConverter.cs 50% <ø> (ø)
src/JsonLD.Entities/NullFrameProvider.cs 100% <ø> (ø)
...c/JsonLD.Entities/Converters/JsonLdSetConverter.cs 50% <ø> (ø)
src/JsonLD.Entities/Context/AutoContextBase.cs 78.26% <ø> (ø)
src/JsonLD.Entities/TypeExtension.cs 100% <100%> (ø)
src/JsonLD.Entities/ContextResolver.cs 90.9% <100%> (ø)
src/JsonLD.Entities/JsonLdContractResolver.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753ba07...13187a3. Read the comment docs.

@tpluscode
Copy link
Contributor Author

Don't know what's going on with failing tests. Waiting for ekonbenefits/dynamitey#26

@tpluscode tpluscode merged commit 21be4e0 into master Jan 3, 2019
@tpluscode tpluscode deleted the netstandard branch January 3, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET Core
1 participant