Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Angular-Capacitor sample to reflect RxJS and Capacitor updates #211

Merged
merged 1 commit into from
May 15, 2023
Merged

Update Angular-Capacitor sample to reflect RxJS and Capacitor updates #211

merged 1 commit into from
May 15, 2023

Conversation

tomek14
Copy link
Contributor

@tomek14 tomek14 commented May 8, 2023

Updated Angular-Capacitor samples to reflect latest updates.

  • Replace deprecated toPromise() with firstValueFrom()
  • Use official CapacitorHttp instead of @capacitor-community/http

Mentioned in #200

@tomek14 tomek14 marked this pull request as ready for review May 8, 2023 20:11
@mraible
Copy link
Collaborator

mraible commented May 15, 2023

Thanks for your contribution, @tomek14!

@mraible mraible merged commit 0d0d23e into wi3land:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraible mraible mraible approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomek14 @mraible