Initial Polars support #1576
Open
Initial Polars support #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-rogers
commented
Nov 4, 2024
richard-rogers
force-pushed
the
dev/richard/polars
branch
from
4a92544
to
2e26e4e
Compare
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
|
|
||
|
|
||
| def test_validator_double_register_udf_polars() -> None: | ||
| global action_list |
There was a problem hiding this comment.
I think we can drop this test.
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
richard-rogers
commented
Nov 7, 2024
Comment on lines
+60
to
+61
| d = {g: grouped.get_group(g) for g in grouped.groups.keys()} | ||
| return d |
There was a problem hiding this comment.
Suggested change
| d = {g: grouped.get_group(g) for g in grouped.groups.keys()} | |
| return d |
richard-rogers
commented
Nov 7, 2024
| if not isinstance(dtype_or_type, type): | ||
| return False | ||
|
|
||
| if issubclass(dtype_or_type, (bool, int, np.number, np.bool_)): | ||
| if issubclass(dtype_or_type, (bool, int, np.number, np.bool_, pl.datatypes.IntegerType)): |
There was a problem hiding this comment.
Suggested change
| if issubclass(dtype_or_type, (bool, int, np.number, np.bool_, pl.datatypes.IntegerType)): | |
| if issubclass(dtype_or_type, (bool, int, np.number, np.bool_)): |
richard-rogers
commented
Nov 7, 2024
| SplitSeries with multiple values, including numpy arrays for numbers, and strings as a Polars Series. | ||
| """ | ||
|
|
||
| # TODO: add a PolarsView, or convert PandasView to work with both Polars & Pandas |
There was a problem hiding this comment.
We should extract a View base class and make ListView, NumpyView, PandasView, PolarsView <: View. PolarsView might be better than NumpyView for ints and floats. PreprocessedColumn would contain a list of View instances rather than members of each specific View subclass.
richard-rogers
commented
Nov 7, 2024
| except Exception as e: # noqa | ||
| new_df[new_col] = pd.Series([None]) | ||
| new_df[new_col] = df.apply_udf(lambda x: float("nan")) # should be None, but can't infer type |
There was a problem hiding this comment.
It might be better to just leave out the failed UDF's output column.
richard-rogers
commented
Nov 13, 2024
python/.pre-commit-config.yaml
Outdated
| exclude: python/whylogs/core/proto/|python/docs/|python/whylogs/viz/html/|java|python/whylogs/api/logger/experimental/logger | ||
| - repo: https://github.com/pre-commit/mirrors-mypy | ||
| rev: v0.942 | ||
| hooks: | ||
| - id: mypy | ||
| language: system | ||
| exclude: ^(python/tests/|python/examples/|python/examples/integration/|python/whylogs/core/proto/|python/docs/|python/whylogs/viz/html/|java|python/whylogs/api/logger/experimental/logger) | ||
| files: ^(python/whylogs/) |
There was a problem hiding this comment.
I'm not positive this check the correct files, but this was the only way I found to get it to not run lint checks on site-packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for logging Polars data frames.
Closes #1230