fix: encode query strings with stricter character set

whoeevee · Dec 30, 2024 · 5aa92eb · 5aa92eb
1 parent b713e92
commit 5aa92eb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/Sources/EeveeSpotify/Lyrics/Repositories/GeniusLyricsRepository.swift b/Sources/EeveeSpotify/Lyrics/Repositories/GeniusLyricsRepository.swift
@@ -26,9 +26,7 @@ struct GeniusLyricsRepository: LyricsRepository {
         var stringUrl = "\(apiUrl)\(path)"
 
         if !query.isEmpty {
-            let queryString = query.queryString.addingPercentEncoding(
-                withAllowedCharacters: .urlHostAllowed
-            )!
+            let queryString = query.queryString
 
             stringUrl += "?\(queryString)"
         }

diff --git a/Sources/EeveeSpotify/Lyrics/Repositories/LrclibLyricsRepository.swift b/Sources/EeveeSpotify/Lyrics/Repositories/LrclibLyricsRepository.swift
@@ -20,9 +20,7 @@ struct LrcLibLyricsRepository: LyricsRepository {
         var stringUrl = "\(apiUrl)\(path)"
 
         if !query.isEmpty {
-            let queryString = query.queryString.addingPercentEncoding(
-                withAllowedCharacters: .urlHostAllowed
-            )!
+            let queryString = query.queryString
 
             stringUrl += "?\(queryString)"
         }

diff --git a/Sources/EeveeSpotify/Models/Extensions/CharacterSet+Extension.swift b/Sources/EeveeSpotify/Models/Extensions/CharacterSet+Extension.swift
@@ -0,0 +1,9 @@
+import Foundation
+
+extension CharacterSet {
+    static var urlQueryAllowedStrict: CharacterSet {
+        var allowed = CharacterSet.urlQueryAllowed
+        allowed.remove(charactersIn: "/?@&=+$")
+        return allowed
+    }
+}
diff --git a/Sources/EeveeSpotify/Models/Extensions/Dictionary+Extension.swift b/Sources/EeveeSpotify/Models/Extensions/Dictionary+Extension.swift
@@ -3,9 +3,13 @@ import Foundation
 extension Dictionary {
     var queryString: String {
         return self
-            .compactMap({ (key, value) -> String in
-                return "\(key)=\(value)"
+            .compactMap({ (key, value) -> String? in
+                guard let keyString = "\(key)".addingPercentEncoding(withAllowedCharacters: .urlQueryAllowedStrict),
+                      let valueString = "\(value)".addingPercentEncoding(withAllowedCharacters: .urlQueryAllowedStrict) else {
+                    return nil
+                }
+                return "\(keyString)=\(valueString)"
             })
-        .joined(separator: "&")
+            .joined(separator: "&")
     }
 }