Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 498: Integrate the Churn Gem and Write a Learning Test to Understand Parts of the Interface RubyCritic Cares About #499

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

hemalvarambhia
Copy link

@hemalvarambhia hemalvarambhia commented Dec 4, 2024

Issue: #498
Check list:

@hemalvarambhia hemalvarambhia marked this pull request as draft December 4, 2024 22:43
@hemalvarambhia hemalvarambhia changed the title 498 integrate churn Issue 498: Integrate the Churn Gem and Write a Learning Test to Understand Parts of the Interface RubyCritic Cares About Dec 4, 2024
@hemalvarambhia hemalvarambhia marked this pull request as ready for review December 8, 2024 16:58
@hemalvarambhia
Copy link
Author

hemalvarambhia commented Dec 8, 2024

Interesting! I ran git log -1 ... as follows

git log -1 --date=iso --follow --format='format:%H date:%x09%ad' -- lib/rubycritic/report_generators/reporter.rb

and the last commit made to file in the test (lib/rubycritic/report_generators/reporter.rb) was:

6733757b8ad103785f464c32381c5681c723888e date: 2014-05-15 00:28:35 +0100

when it was deleted.

The test in question (test/lib/rubycritic/source_control_systems/git/churn_test.rb:31) says that the last commit involving the file is '2014-03-19 18:17:28 +0000'. What am I missing?

@hemalvarambhia
Copy link
Author

@etagwerker so far, how does the work presented here look? Is there more I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant