Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for when still running on ruby 2.7 #480

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

faisal
Copy link
Contributor

@faisal faisal commented Mar 2, 2024

Bump cucumber, minitest, parser, rake, reek, rubocop, and ruby_parser dependencies.

This is a pull request to update dependencies, intended for landing as part of an update that we put together for other reasons. I expect to update it from time to time when I notice other relevant dependency updates.

Check list:

@faisal faisal force-pushed the dependency_bumps_over_4_9_0 branch 2 times, most recently from 1750ae9 to fb22085 Compare March 2, 2024 21:36
Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal This looks good, thanks! Before I merge it, I'd like to know what you think about #482

We might want to start requiring Ruby 3.0 or higher in order to have more current core dependencies (e.g. reek)

@faisal
Copy link
Contributor Author

faisal commented Mar 3, 2024

I'll comment more fully there, but for purposes of this PR I do think that supporting Ruby 2.7 is starting to hold us back. For example, I believe that updating the minimum Ruby to 3.0 would allow currently us to pull our dependencies up to minitest 5.22.2, rake 13.1.0, and rubocop 1.61.0.

@faisal
Copy link
Contributor Author

faisal commented Mar 3, 2024

I started a branch for dropping 2.7 support. Once we know what we're doing with this PR, it should be a quick turn to make a PR out of that branch.

@faisal faisal force-pushed the dependency_bumps_over_4_9_0 branch from fb22085 to 49cd616 Compare March 19, 2024 16:10
@faisal faisal force-pushed the dependency_bumps_over_4_9_0 branch from 49cd616 to b1f7add Compare April 2, 2024 02:14
@faisal faisal changed the title WIP: Bump dependencies WIP: Bump dependencies for when still running on ruby 2.7 Apr 2, 2024
@faisal faisal force-pushed the dependency_bumps_over_4_9_0 branch from b1f7add to 338468f Compare April 2, 2024 02:28
@faisal faisal changed the title WIP: Bump dependencies for when still running on ruby 2.7 Bump dependencies for when still running on ruby 2.7 Apr 5, 2024
…_parser dependencies

Also address Lint/UselessAssignment and Style/MapIntoArray warnings that newer versions of rubocop will complain about on newer versions of Ruby.
@faisal faisal force-pushed the dependency_bumps_over_4_9_0 branch from 338468f to 59b1e1d Compare April 10, 2024 23:59
@faisal
Copy link
Contributor Author

faisal commented Apr 11, 2024

Is it worth integrating the fix from #486 ?

Copy link
Collaborator

@nunosilva800 nunosilva800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Reek 6.2+ requires ruby 3, we can make RubyCritic v4.9.x the last one with ruby 2.7 support.

We can either require a min of ruby v3.0.0 in RubyCritic v4.10, or make it v5.0. Don't really have a strong opinion on this.

rubycritic.gemspec Outdated Show resolved Hide resolved
@nunosilva800 nunosilva800 merged commit e62770b into whitesmith:main Apr 14, 2024
26 checks passed
@faisal faisal deleted the dependency_bumps_over_4_9_0 branch April 14, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants