[feature/InhaBas#204] review 반영 코드 수정

whitem4rk · Jan 4, 2024 · b0584c7 · b0584c7
1 parent bbad31f
commit b0584c7
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 13 deletions.
diff --git a/...erver/src/test/java/com/inhabas/api/domain/board/domain/valueObject/BoardContentTest.java b/...erver/src/test/java/com/inhabas/api/domain/board/domain/valueObject/BoardContentTest.java
@@ -26,20 +26,23 @@ public void Contents_is_too_long() {
 
         //then
         assertThatThrownBy(() -> new Content(contentsString))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 
     @DisplayName("Content 타입에 공백을 저장할 수 없다.")
     @Test
     public void Contents_is_Empty() {
         assertThatThrownBy(() -> new Content(""))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 
     @DisplayName("Content 타입에 null 은 허용 안된다.")
     @Test
     public void Contents_is_Null() {
         assertThatThrownBy(() -> new Content(null))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 }
diff --git a/resource-server/src/test/java/com/inhabas/api/domain/board/domain/valueObject/TitleTest.java b/resource-server/src/test/java/com/inhabas/api/domain/board/domain/valueObject/TitleTest.java
@@ -30,20 +30,23 @@ public void Title_is_too_long() {
 
         //then
         assertThatThrownBy(() -> new Title(titleString))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 
     @DisplayName("제목은 null 일 수 없습니다.")
     @Test
     public void Title_cannot_be_Null() {
         assertThatThrownBy(() -> new Title(null))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 
     @DisplayName("제목은 빈 문자열일 수 없습니다.")
     @Test
     public void Title_cannot_be_Blank() {
         assertThatThrownBy(() -> new Title(""))
-                .isInstanceOf(InvalidInputException.class);
+                .isInstanceOf(InvalidInputException.class)
+                .hasMessage("입력값이 없거나, 타입이 유효하지 않습니다.");
     }
 }
diff --git a/resource-server/src/test/java/com/inhabas/api/domain/club/dto/ClubHistoryDtoTest.java b/resource-server/src/test/java/com/inhabas/api/domain/club/dto/ClubHistoryDtoTest.java
@@ -1,6 +1,5 @@
 package com.inhabas.api.domain.club.dto;
 
-import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.DisplayName;
@@ -13,6 +12,8 @@
 import java.time.LocalDateTime;
 import java.util.Set;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 class ClubHistoryDtoTest {
 
     private static ValidatorFactory validatorFactory;
@@ -45,7 +46,7 @@ void Positive_Test() {
         Set<ConstraintViolation<ClubHistoryDto>> violations = validator.validate(clubHistoryDto);
 
         //then
-        Assertions.assertThat(violations.size()).isEqualTo(2);
+        assertThat(violations).hasSize(2);
 
     }
 
@@ -65,7 +66,7 @@ void NotNull_Test() {
         Set<ConstraintViolation<ClubHistoryDto>> violations = validator.validate(clubHistoryDto);
 
         //then
-        Assertions.assertThat(violations.size()).isEqualTo(3);
+        assertThat(violations).hasSize(3);
 
     }
 

diff --git a/...-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java b/...-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java
@@ -24,7 +24,9 @@
 import java.util.List;
 import java.util.Optional;
 
-import static org.assertj.core.api.Assertions.*;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.assertj.core.api.Assertions.tuple;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.BDDMockito.then;
@@ -76,7 +78,8 @@ void writeClubHistory_Member_Not_Found() {
 
         // then
         assertThatThrownBy(() -> clubHistoryService.writeClubHistory(1L, saveClubHistoryDto))
-                .isInstanceOf(MemberNotFoundException.class);
+                .isInstanceOf(MemberNotFoundException.class)
+                .hasMessage("존재 하지 않는 유저입니다.");
 
     }
 
@@ -97,7 +100,8 @@ void findClubHistory_Success() {
 
         //then
         then(clubHistoryRepository).should().findById(any());
-        assertThat(clubHistoryDto).extracting("title", "content")
+        assertThat(clubHistoryDto).as("clubHistoryDto's title and content are equal to clubHistory")
+                .extracting("title", "content")
                 .containsExactly(clubHistory.getTitle().getValue(), clubHistory.getContent().getValue());
 
     }
@@ -110,7 +114,8 @@ void findClubHistory_Not_Found() {
 
         //then
         assertThatThrownBy(() -> clubHistoryService.findClubHistory(any()))
-                .isInstanceOf(NotFoundException.class);
+                .isInstanceOf(NotFoundException.class)
+                .hasMessage("데이터가 존재하지 않습니다.");
 
     }