Refactor to oop approach #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note Issue #53 , there probably is an easier way to retrieve all the data using the 'new' API. |
Good one |
|
Hey @miritreus, I found that the scraping module fails when the I believe it is worth limiting the 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to propose a more object oriented approach with this PR. Most notably, the fetching of the html is separated from the extraction of the data from the fetched html pages. The fetched html is saved. The following folder structure is used:
Also fixed some css selectors and did some renaming along the way.
Still lots of room for improvement, but this is a start.