Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unicode serialization of an origin #2689

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented May 16, 2017

And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Fixes #2568.

And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Fixes #2568.
annevk added a commit to whatwg/url that referenced this pull request May 16, 2017
See whatwg/html#2568 for discussion.

See whatwg/html#2689 for the corresponding
change to the HTML Standard.

Closes #297.
@annevk annevk added removal/deprecation Removing or deprecating a feature topic: origin labels May 16, 2017
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, although I will let you decide when landing this is good, with regard to the corresponding URL spec changes and tests.

annevk added a commit to web-platform-tests/wpt that referenced this pull request May 17, 2017
@annevk
Copy link
Member Author

annevk commented May 17, 2017

This should land first with a pointer to all the tests and the corresponding URL Standard change. Then the URL Standard change can land a day later when the terms are indexed by Shepherd. I'm not in a rush since I don't think this will conflict much so I'll give folks another 24h or so.

@annevk annevk merged commit 59ebd9c into master May 18, 2017
@annevk annevk deleted the annevk/origin-serialization branch May 18, 2017 04:25
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 18, 2017
annevk added a commit that referenced this pull request May 19, 2017
annevk added a commit to whatwg/url that referenced this pull request May 19, 2017
See whatwg/html#2568 for discussion.

See whatwg/html#2689 for the corresponding
change to the HTML Standard.

Tests: web-platform-tests/wpt#5944.

Closes #297.
domenic pushed a commit that referenced this pull request May 19, 2017
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
rmisev added a commit to upa-url/upa that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature topic: origin
Development

Successfully merging this pull request may close these issues.

3 participants