refactor #2
refactor #2
Conversation
| @@ -126,7 +124,6 @@ func uploadResolverFiles(dataFiles []string) { | |||
| } | |||
|
|
|||
| func TestCorrectClientWithS3(t *testing.T) { | |||
| go minio.Main(args) | |||
There was a problem hiding this comment.
Minio didn't want to start so I added compose and gh action service. I also tried start it with our certificates as was starting this one but there was issue with missing SAN and I don't want to spend time on generating new certs. From my point of view it's ok without HTTPS in tests.
| if err != nil { | ||
| log.Fatal(MSG00023, err) | ||
| } | ||
| } | ||
| if len(crlBytes) > 1 { | ||
| settings.crl, err = x509.ParseCRL(crlBytes) | ||
| settings.CRL, err = x509.ParseRevocationList(crlBytes) |
There was a problem hiding this comment.
This is interesting. Original method is deprecated and new one doesn't support PEM format. So I converted PEM to DER (certs/crl/certs/intermediate.crl.der) and it works.
There was a problem hiding this comment.
In following PR I added support for PEM back and decoding it to DER before ParseRevocationList call. So it's fully backward compatible.
|
|
||
| issues: | ||
| # run linter only on commits after the rev | ||
| new-from-rev: ed3a1c1c84ac975b595d199b15209c3401515bff |
There was a problem hiding this comment.
Too many lint issues so I enabled it only for new changes.
| } | ||
| interaction(t, "unknown-client", []string{}, []string{"SSL_ERROR_BAD_CERT_ALERT", "alert bad certificate"}, "", props) | ||
| interaction(t, "unknown-client", []string{}, []string{"TLS alert, unknown CA (560)", "alert unknown ca"}, "", props) |
There was a problem hiding this comment.
This is caused by curl changed output. It was quite detective work but I tried old fedora and it matched original error message so I'm confident it's ok. Also commend in Dockerfile:7 added some confidence (it failed on new versions even then).
No description provided.