Adding our customization to Zeppelin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zarquan
suggested changes
Feb 19, 2023
There was a problem hiding this comment.
Almost, but what happens when we want to add another logo next week ?
We need to include our version number as well, so that we can create more than one version of our modified product.
I take it that changing the product name from zeppelin to gaia-dmp-zeppelin was going to be difficult. In which case:
{the-thing}-{their-version}-{our-brand}-{our-version}.{type}
{zeppelin}-{0.10.1}-{gaia-dmp}-{0.1}.{tar.gz}
So the 'version' in the Maven script would be 0.10.1-gaia-dmp-0.1, allowing us to have 0.10.1-gaia-dmp-0.2 next week.
|
Ok, new commit now sets the version to match your proposal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Adding our customization changes for Gaia to Zeppelin
What type of PR is it?
Feature