-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken devtools with dynamic path #200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ggomaeng is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
Update: Transaction seems to work after clean fork of the frog repo and building on top of it. |
@tmm do you think I am on the right track with this solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it and confirm that the patch solves the issue.
Added new catch all route in
frog-base.tsx
so it's the first route prioritized to be used for devtools whenthis_dev
is set. Ifthis_dev
is not set, it just relays the request.Since devtools is registered at the end of all the route definition to have information about existing roots, having any dynamic path before devtools will have higher priority over the devtools path & devtools will become obsolete.
This fixes #176 - this problem exists not only in Next.js, but also in other environments as well.
Tested on my end and everything seems to work! including transactions 👍
Minimal reproduction repo
https://github.com/ggomaeng/frog-dynamic-route-minimal-reproduction
http://localhost:3000/api/dev
To test this PR
http://localhost:3000/api/dev
Steps To Reproduce
Frog Version
0.7.13
cc @Seranged, @christopherwxyz, @chuckstock.