Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAUTRE] Add paginate to index views #7

Closed
wants to merge 1 commit into from
Closed

[FEAUTRE] Add paginate to index views #7

wants to merge 1 commit into from

Conversation

PauSentis
Copy link

Description

Added pagination components to improve navigation in index views for translation apps and translations.

@westonganger
Copy link
Owner

westonganger commented Sep 30, 2023 •
edited
Loading

Thanks for catching this.

  1. The default styling of the pagination is not good. Can you run the following command to generate the appropriate bootstrap views for kaminari and thne commit the files that are added as part of this PR. bundle exec rails g kaminari:views bootstrap4
  2. Can we add a changelog entry for this.

@westonganger westonganger mentioned this pull request Oct 14, 2023
Merged
@westonganger
Copy link
Owner

Thanks for this. But since I didnt recieve a response yet I have replaced this PR with #10 which includes the proper bootstrap styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PauSentis @westonganger