[FIX] GoogleTranslate errors #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| module RailsI18nManager | |||
| module GoogleTranslate | |||
| require 'easy_translate' | |||
There was a problem hiding this comment.
According to general ruby standards, require statements should be at the top of the file not within a class or method.
But I would prefer we do all of our dependency require statements in lib/rails_i18n_manager/engine.rb
| @@ -13,7 +14,7 @@ def self.translate(text, from:, to:) | |||
| return nil | |||
| end | |||
|
|
|||
| EasyTranslate.translate(text, from: from, to: to, key: api_key) | |||
| translation = EasyTranslate.translate(text, from: from, to: to, key: api_key) | |||
There was a problem hiding this comment.
This looks fine for this PR. Though I wonder why we have some complexity in the statements below. They probably need to be refractored a bit.
if translation
str = translation.to_s
if str.present?
|
I've made one comment to address. Would you also mind adding a changelog entry? |
|
Looks like we should add at least one passing spec for this class |
|
Thanks for these fixes however I've added a more complete solution including adding specs for this class. See #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the Google Translate functionality in
RailsI18nManager::GoogleTranslatemodule. The following fixes have been implemented:require 'easy_translate'statement to ensure proper dependency utilization.This fix ensures that the Google Translate functionality now operates as intended, allowing for accurate translations and resolving any previous errors.