Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width issue on translation values form and view page #19

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix width issue on translation values form and view page #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Unreleased - [View Diff](https://github.com/westonganger/rails_i18n_manager/compare/v1.0.1...master)
- Drop support for Rails v5.x
- [#19](https://github.com/westonganger/rails_i18n_manager/pull/19) - Fix width issue on translation values form and view page

### v1.0.1 - [View Diff](https://github.com/westonganger/rails_i18n_manager/compare/v1.0.0...v1.0.1)
- [#14](https://github.com/westonganger/rails_i18n_manager/pull/14) - Remove usage of Array#intersection to fix errors in Ruby 2.6 and below
Expand Down
4 changes: 2 additions & 2 deletions app/views/rails_i18n_manager/form_builder/_basic_field.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
options[:label_wrapper_html][:class].concat(" col-md-1 col-form-label text-md-end").strip!

options[:input_wrapper_html][:class] ||= ""
options[:input_wrapper_html][:class].concat(" col-auto g-md-0").strip!
options[:input_wrapper_html][:class].concat(" col-md-11").strip!
end

if type == :text_area
Expand Down Expand Up @@ -49,7 +49,7 @@

<% field = capture do %>
<% if type == :view %>
<%= text_field_tag nil, options[:input_html][:value], options[:input_html] %>
<%= text_area_tag nil, options[:input_html][:value], options[:input_html] %>
<% elsif type == :select %>
<%=
f.select(
Expand Down
2 changes: 1 addition & 1 deletion app/views/rails_i18n_manager/translations/_translation_value_fields.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@

.nested-fields.translation-value-fields
= f.hidden_field :locale
= f.field :translation, type: :textarea, label: "#{locale}", required: required, help_text: help_text, field_layout: :horizontal, input_html: {rows: 1, width: "100%;"}
= f.field :translation, type: :textarea, label: "#{locale}", required: required, help_text: help_text, field_layout: :horizontal, input_html: {rows: 1}
Loading