Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested resource YAML config. #51

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yuanping
Copy link

Support nested resource or namespace resource YAML config:
<%= editable [:admin, @order], :title %>

}

.editable-error {
color: red;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color red should be written in hexadecimal form as #ff0000
Line should be indented 2 spaces, but was indented 3 spaces

@jirikolarik
Copy link
Member

Please rebase

}
.input-daterange input:last-child {
-webkit-border-radius: 0 3px 3px 0;
-moz-border-radius: 0 3px 3px 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid vendor prefixes.

-webkit-transition: background-color 1400ms ease-out;
-moz-transition: background-color 1400ms ease-out;
-o-transition: background-color 1400ms ease-out;
-ms-transition: background-color 1400ms ease-out;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid vendor prefixes.

@jirikolarik
Copy link
Member

Ping @yuanping


if xeditable?(object)
model = object.class.name.split('::').last.underscore
model = model_name || object.class.name.split('::').last.underscore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants