Fix tests on MacOS #266
Merged
Fix tests on MacOS #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same thing in the tutorial servers, except binding the IPv4 wildcard instead of localhost as tutorial users might run the servers and clients on different machines. |
|
Ah. Yes, we already fixed this in some other tests, sorry that we missed a few! Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Issue238 tests failed on MacOS with "connection refused" in the client, but suspiciously all other tests passed. It took me longer than I'd like to admit to figure out why this was the case, but it's because these tests don't use the shared
testClientServerdriver that all of the other ones do. Instead, their owntestWithpassesNothingas the bind addr, and on MacOS that winds up making an IPv6 socket and binding it to::. On Linux, one of two things prevents this from being a problem depending on the setup:IPV6_V6ONLYoption is0by default (the manpage says that this can vary at runtime by some unspecified mechanism and programs must check/proc/sys/net/ipv6/bindv6onlyif they want to know the default value)Providing an IPv4 bind address fixes this issue on MacOS.