Feat/cd workflow. Android #92
Conversation
…-native-template into feat/cd-workflow
|
Warning Rate Limit Exceeded@himanshu-wedensday has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update introduces a GitHub Actions workflow tailored for automating the Android app build and release process. It streamlines tasks like dependency management, APK building, version control, and APK upload to GitHub releases. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Test suite run success54 tests passing in 24 suites. Report generated by 🧪jest coverage report action from c37102a |
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
.github/workflows/android-build.yml
Outdated
| name: Build and Release Android App | ||
| on: | ||
| push: | ||
| branches: | ||
| - feat/cd-workflow | ||
| tags: | ||
| - v* | ||
| permissions: |
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has revealed that while the tag pattern 'v*' is actively used in the repository, the branch 'feat/cd-workflow' does not exist. This discrepancy suggests that the workflow might not trigger as expected unless the branch is created or the workflow configuration is adjusted to reflect the actual branching strategy used in the project.
- The tag pattern 'v*' is correctly used and matches the workflow configuration.
- The branch 'feat/cd-workflow' does not exist in the repository.
Analysis chain
Ensure the workflow name and trigger conditions align with your project's branch and tagging conventions.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the branch 'feat/cd-workflow' exists
git branch --list 'feat/cd-workflow'
# Verify that the tag pattern 'v*' is used in the repository
git tag --list 'v*'
Length of output: 90
.github/workflows/android-build.yml
Outdated
| id: upload-release-asset | ||
| uses: actions/upload-release-asset@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps | ||
| asset_path: ./app/build/outputs/apk/debug/app-debug.apk | ||
| asset_name: app-debug.apk | ||
| asset_content_type: application/zip |
There was a problem hiding this comment.
Ensure the asset path and content type are correct for the APK being uploaded to the release. The asset path seems to point to a debug APK, which might be incorrect.
- asset_path: ./app/build/outputs/apk/debug/app-debug.apk
+ asset_path: ./android/app/build/outputs/apk/release/app-release.apkCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| id: upload-release-asset | |
| uses: actions/upload-release-asset@v1 | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| with: | |
| upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps | |
| asset_path: ./app/build/outputs/apk/debug/app-debug.apk | |
| asset_name: app-debug.apk | |
| asset_content_type: application/zip | |
| id: upload-release-asset | |
| uses: actions/upload-release-asset@v1 | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| with: | |
| upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps | |
| asset_path: ./android/app/build/outputs/apk/release/app-release.apk | |
| asset_name: app-debug.apk | |
| asset_content_type: application/zip |
This comment has been minimized.
This comment has been minimized.
himanshu-wedensday
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
himanshu-wedensday
force-pushed
the
feat/cd-workflow
branch
from
cbf5ecb
to
9889ec9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: wednesday-solutions_react-native-template_AY7hdnRSB2n8RRmGoU2M |
Ticket Link
Related Links
Description
Steps to Reproduce / Test
GIF's
Summary by CodeRabbit