This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Proposed solution to the path variable being incremented (Issue #54) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nova#54) This should create a duplicate of the "$.fn.wPaint.menus[this.name]" object rather than referencing and modifying the original
|
Tested - solution works well |
|
Would like to see this merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are a couple proposed solution to this issue, however I believe this would be the most effective method.. The root of the problem appeared to be that the original object array was being modified, and every time the plugin was reinitialized that array was being modified over again.
Both of the other solutions basically just check the
imgvariable do determine whether it exists (#73) or has already had the path variable prepended to it (#81).This should create a duplicate of the
$.fn.wPaint.menus[this.name]object rather than referencing and modifying the original.