feat: reduce unnecessary exports runtime #18565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The initial goal of this PR is to reduce unnecessary runtime code in
modern-module
. As__webpack_exports__
and related define property runtime is not needed.Contains following changes:
Explicit define
RuntimeGlobals.exports
instead of using the always pre-rendered__webpack_exports__
in source, only render it when runtime requirements exist.RuntimeGlobals.onChunksLoaded
is added, also addingRuntimeGlobals.exports
RuntimeGlobals.exports
tolib/library/AssignLibraryPlugin.js
andlib/library/ExportPropertyLibraryPlugin.js
to inherit the explicit definedRuntimeGlobals.exports
runtime.Do not render
RuntimeGlobals.exports
&RuntimeGlobals.definePropertyGetters
in modern-module mode.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
I don't think so.
__webpack_exports__
is striped only when is useless.What needs to be documented once your changes are merged?
No.