Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appinfo: add deeplinking/voicesearch options #5

Merged
merged 6 commits into from
Dec 20, 2021
Merged

appinfo: add deeplinking/voicesearch options #5

merged 6 commits into from
Dec 20, 2021

Conversation

Informatic
Copy link
Member

@Informatic Informatic commented Dec 13, 2021 •
edited
Loading

Fixes #1 , FriedChickenButt#29.

Verified on webOS 3.8 with voice search. Also fixes in-app voice search on webOS 5.x as reported on Discord directly.

We also add an unknown option that possibly fixes FriedChickenButt#25

@fire332
Copy link
Collaborator

fire332 commented Dec 14, 2021

Does not work for videos directly from home deck on webOS 6. Seems like prepending v= is redundant.
image

@Informatic
Copy link
Member Author

youtube.leanback.v4_0.1.1_all.zip
Try this one out please.

@Informatic
Copy link
Member Author

Informatic commented Dec 14, 2021 •
edited
Loading

youtube.leanback.v4_0.1.1_all-contentTarget.zip
also possibly this one too - I've reverted a change that caused breakage on some versions, but improved startup/relaunch time on some other versions...

@fire332
Copy link
Collaborator

fire332 commented Dec 14, 2021 •
edited
Loading

I don't think that's the proper way of handling the double v=. I found this dump (https://pastebin.com/uZ99hPGQ) and on line 6165, the youtube appinfo does not use v= for the deeplinkingParams but does use q= for the inAppSearchParams on line 6132

@Informatic
Copy link
Member Author

This is all very webOS version dependent. On webOS 5.x $CONTENTID does indeed contain v=, while on webOS 4.x and 3.x it does not. I think it should be fairly safe this way...

The question now is whether or not any/both of these versions work for you properly now?

@fire332
Copy link
Collaborator

fire332 commented Dec 19, 2021 •
edited
Loading

Both of them don't work when launching the app directly. In another note, I found a video where the screensaver keeps triggering. https://www.youtube.com/watch?v=wagmJMypQ1U

image
image

@Informatic
Copy link
Member Author

Ah yeah, that's my bad. :/ This is what I get for rolling out a test release without testing. Sorry.
youtube.leanback.v4_0.1.1_all-contentTarget2.zip

@Informatic
appinfo: add supportGIP
471729c 
With this enabled, anyone willing to have youtube autostart can run:

luna-send -n 1 'luna://com.webos.service.eim/addDevice'
'{"appId":"youtube.leanback.v4","pigImage":"","mvpdIcon":""}'

Sadly we cannot run this from the app itself, since netcast trustLevel
disables luna bus access.
@Informatic
CI: upload artifacts in PRs
42f7a65
@BDvirus
Copy link

BDvirus commented Dec 20, 2021

Thank you!! it's working :)
Tested with webos 6 (03.20.80)

@Informatic Informatic marked this pull request as ready for review December 20, 2021 17:08
@Informatic
Copy link
Member Author

Merging in then.

@Informatic Informatic closed this Dec 20, 2021
@Informatic
Copy link
Member Author

Dammit.

@Informatic Informatic reopened this Dec 20, 2021
@Informatic Informatic merged commit b49de4e into main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screen saver issue(s) voice search
3 participants
@Informatic @fire332 @BDvirus