Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address assembling #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

sunkaflek
Copy link

I've made some fixes while repairing about 1000 addresses in a company DB, like de-duplicating town areas, eliminating quotes around company name and taking street number from another element if present. The resulting addresses seem more readable and consistent this way.

@petrparolek
Copy link
Member

could you show an example?

@sunkaflek
Copy link
Author

Hi,

I have since done some further improvements and released my branch as a separate package, as I needed it for a project: https://packagist.org/packages/sunkaflek/ares

Here are some of the resulting differences (left is my branch, right is this package).

I have now used it for fixing about 10 000 records with human oversight, I would recommend merging, along with the newer commits.

Screenshot 2022-05-17 at 14 04 14

Screenshot 2022-05-17 at 14 04 31

Screenshot 2022-05-17 at 14 04 56

@petrparolek petrparolek force-pushed the master branch 7 times, most recently from 52884f7 to 6eecfde Compare April 3, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants