Fix implementsInterface() PHPDoc
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs look good, could you add some test cases using objects, so we cover it in our unit tests? |
herndlm
force-pushed
the
fix-implements-interface-phpdoc
branch
from
d5a97ab to
9ff015b
Compare
sure, adapted |
|
@BackEndTea in case you didn't see it: should be adapted. In case you're just busy: no worries, this is not important 😊 |
shadowhand
requested changes
Oct 15, 2024
shadowhand
approved these changes
Oct 15, 2024
herndlm
force-pushed
the
fix-implements-interface-phpdoc
branch
2 times, most recently
from
2bd8ece to
98b343c
Compare
|
fyi rebased, fixed conflicts and also squashed those 3 commits into one |
shadowhand
reviewed
Oct 17, 2024
herndlm
force-pushed
the
fix-implements-interface-phpdoc
branch
from
98b343c to
ad98127
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class_implementsaccepts either an object or a class-string, but the PHPDoc for the assert function is wrong and limits its functionality to a class-string only. I'm not entirely sure if this was on purpose, the README just mentions "Check that a class implements an interface", but it would work with either an instance of a class or a class-string and the assertion is under the "object" category.See also https://phpstan.org/r/c72bb8af-4f27-462b-85f6-e2d3b81b9786 where this is tested in PHPStan (which just got support for PHPDoc-based type narrowing, this is not released yet)
Refs: phpstan/phpstan-webmozart-assert#144 (comment)
I could not cleanly run psalm locally without unrelated errors, let's see what happens on CI 🤞