Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pro badge to bdb #5160

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add pro badge to bdb #5160

wants to merge 4 commits into from

Conversation

Bestem0r
Copy link
Contributor

@Bestem0r Bestem0r commented Nov 6, 2024

Description

Adds the "PRO" badge to BDB.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
image image
image image

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1083

@Bestem0r Bestem0r added the review-needed Pull requests that need review label Nov 6, 2024
Copy link

linear bot commented Nov 6, 2024

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 8:06pm

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀


return (
<Page
title={title}
actionButtons={<LinkButton href="/bdb/add">Ny bedrift</LinkButton>}
tabs={<BdbTabs />}
>
<Helmet title={title} />
<Helmet title="BDB" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Helmet title="BDB" />
<Helmet title="Bedriftsdatabase" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "BDB PRO" now, no longer "Bedriftsdatabase"

app/routes/bdb/components/bdb.module.css Outdated Show resolved Hide resolved
Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@Viljen789
Copy link
Contributor

LGTM!!!

Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants