Add PHP 8.3 support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme still contained PHP versions that aren't supported anymore
Error: Function utf8_encode() is deprecated in /srv/esb/vendor/monolog/monolog/src/Monolog/Utils.php on line 179 Resolved with: Implementing Monolog\Utils::detectAndCleanUtf8() from Monolog version 2.8
To avoid dependency conflicts with project dependencies, require BC Check tool in a separate directory
mmenozzi
reviewed
Oct 28, 2024
Comment on lines
+41
to
+43
| "suggest": { | ||
| "ext-mbstring": "*" | ||
| }, |
There was a problem hiding this comment.
We should move this to the requirements so we can remove the mb_convert_encoding symbol from the composer require checker whitelist.
Comment on lines
+4
to
+5
| "null", "true", "false", "static", "self", "parent", | ||
| "array", "string", "int", "float", "bool", "iterable", "callable", "void", "object", "mixed", "never", |
There was a problem hiding this comment.
Why are those core symbols whitelisted? There weren't the need to whitelist them previously...
|
I'm going to close this in favor of #38 as I had to do some changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PHP versions 8.1 till 8.3
Pending webgriffe/amp-elasticsearch#6