Call reset on the logger in order to clean buffers #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the section "Long running processes and avoiding memory leaks" here:
We should call
$logger->reset();
in all appropriate points of ProducerInstance and WorkerInstance, in order to "properly execute" buffered monolog handler. This is especially important when using a "DeduplicationHandler": with the actual implementation it doesn't not send emails immediatly (even tho it should) until the ESB is stopped.I am not really experienced on the ESB internal, so i don't know if they points that i modified are ok, or there are ones in which we can call the "reset".