Fix new Psalm and PHPStan errors (#187)

webgriffe · Nov 17, 2023 · a984b5e · a984b5e
1 parent 5d1746b
commit a984b5e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -10,7 +10,8 @@
     <projectFiles>
         <directory name="src" />
         <ignoreFiles>
-            <directory name="vendor" />
+            <directory name="vendor"/>
+            <file name="src/DependencyInjection/Configuration.php"/>
         </ignoreFiles>
     </projectFiles>
 

diff --git a/src/Middleware/ItemImportResultPersisterMiddleware.php b/src/Middleware/ItemImportResultPersisterMiddleware.php
@@ -36,7 +36,7 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
                 return $result;
             }
 
-            if (!$envelope->last(ReceivedStamp::class)) {
+            if (null === $envelope->last(ReceivedStamp::class)) {
                 return $result;
             }
 

diff --git a/src/Product/ProductOptionsResolver.php b/src/Product/ProductOptionsResolver.php
@@ -12,6 +12,9 @@
 use Sylius\Component\Product\Repository\ProductOptionRepositoryInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
 
+/**
+ * @psalm-type AkeneoFamilyVariant array{code: string, labels: array<string, ?string>, variant_attribute_sets: list<array{level: int, axes: list<string>, attributes: list<string>}>}
+ */
 final class ProductOptionsResolver implements ProductOptionsResolverInterface
 {
     /**
@@ -55,6 +58,7 @@ public function resolve(array $akeneoProduct): array
         $familyVariantCode = $productResponse['family_variant'];
 
         try {
+            /** @var AkeneoFamilyVariant $familyVariantResponse */
             $familyVariantResponse = $this->apiClient->getFamilyVariantApi()->get($familyCode, $familyVariantCode);
         } catch (HttpException $e) {
             if ($e->getResponse()->getStatusCode() === 404) {