Disconnect realms when leave page. #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctrlaltdavid is attempting to deploy a commit to the WEBA Team on Vercel. To accomplish this, @ctrlaltdavid needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network realms are now disconnected from when the scene unloads. The commented-out code in TitleScreen.jsx lines 876 - 878 should be able to be enabled so that network realms are automatically connected when the title scene loads, and the 'm' key code removed and the commented-out code in TitleScreen.jsx lines 876 - 878 enabled.
As part of this, associated changes have been made:
TitleScreenRendererupon window unload. (This disconnects network realms.)TypeError: Cannot read properties of null (reading 'dataClient')error when press 'm' key in first title scene. Multiplayer additions and fixes. webaverse/multiplayer-do#9 )