Respect rte allow tags in translate request #288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
approved these changes
Jul 21, 2023
sbuerk
requested changes
Jul 21, 2023
|
At first the PR was working for my case. However with some more testing i encountered the following. I have bodytext with the text:
I did a test case with a glossary (replace words with my and colleagues name): cheese with NL translation = 'joey' the translation result was:
Something still seems to be incorrect here. Edit: Adding |
NarkNiro
force-pushed
the
wv_deepletranslate-278
branch
from
36b8c00 to
c888183
Compare
With this change the RTE configuration is determined from the field to be translated. To give deepl a list of allowed HTML tags. To allow a correct separation in the translated text with HTML tag.
NarkNiro
force-pushed
the
wv_deepletranslate-278
branch
from
c888183 to
2187a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the RTE configuration is determined from the field to be translated. To give deepl a list of allowed HTML tags.
To allow a correct separation in the translated text with HTML tag.
Resolve #278