Skip to content

Commit

Permalink
[TASK] Ensure working PageLayout localization modal for v13
Browse files Browse the repository at this point in the history
TYPO3 changes in a lot of areas including the backend JavaScript
and CSS definition where the most part are taken as internal and
not as public API. This can change in even in LTS versions, but
most likely in newer major versions.

With TYPO3 v13 context aware lightning (light/dark mode) has been
introduces which is a hard thing for icons in regards of readability.

To ensure that the `DeepL Translate` part within this localization
model works for TYPO3 v13 this change ...

* Adds the overriden TypeScript file along with the compiled JavaScript
  (compiled within a TYPO3 13.4 monorepo !) as documentation while also
  providing the compiled JavaScript in the public resources folder with
  a core version suffix while keeping the compiled v12 variant.
* Modifies the `Configuration/JavaScriptModules.php` to override the
  TYPO3 core `localization` file with the custom file based for the
  current used core version.
* Duplicates the action icon svg, slightly modified to be context aware
  and using the `currentColor` defined by the context to suite in both
  modes (light and dark).
* Adds a custom CSS file to define a custom CSS class used within the
  overriden localization JavaScript code to ensure that icon labels
  breaks correctly. Workaround for a core bug in this area. [1][2]
* Enforce loading the action icon as inline within the overriden
  localization JavaScript file to include the svg - otherwise the
  theme based context color would not take effect, which works
  around another known TYPO3 core bug.
* A smaller unnice handling issue checking the extension configuration
  to allow or deny the next step for the deepltranslate modes has been
  streamlined as a side change. Mainly v13, v12 only partly due to
  general overhaul in TYPO3 v13.
* Deepltranslate alert info when configuration is not fullfilled are
  no longer closeable (v12 + v13).

The build system for the TypeScript -> JavaScript **must** be revised
in the next year (2025) to be capable of building against multiple
core versions. The v13 has been compiled and extracted directly in a
TYPO3 Core Development instance using the monorepo on branch 13.4.

[1] https://forge.typo3.org/issues/105853
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/87576
  • Loading branch information
sbuerk committed Dec 20, 2024
1 parent 0380498 commit 1eafd9d
Show file tree
Hide file tree
Showing 11 changed files with 566 additions and 8 deletions.
13 changes: 13 additions & 0 deletions Build/Sources/Core13/localization.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1eafd9d

Please sign in to comment.