[streams] Add tests for aborting pipeTo() #13358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for aborting ReadableStream.prototype.pipeTo using an AbortSignal. Tests correspond to PR whatwg/streams#744.
wpt-pr-bot
requested review from
calvaris,
domenic,
wanderview,
youennf and
yutakahirano
ricea
added a commit
to whatwg/streams
that referenced
this pull request
Oct 4, 2018
The reference implementation now supports the "signal" option to pipeTo(). It has diverged from the standard text, which will be updated separately. Tests are at web-platform-tests/wpt#13358.
domenic
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Overall LGTM, some minor suggestions. A bit amused that almost all of the tests use an already-aborted signal, but I guess that's where the edge cases lie.
OK, here's a suggestion: wait for the pipe to complete successfully, then abort the signal, and make sure that doesn't somehow error/cancel the streams? I dunno, maybe that's too silly.
streams/piping/abort.js
Outdated
| } | ||
| }); | ||
| const ws = new WritableStream(); | ||
| return promise_rejects(t, new TypeError(), rs.pipeTo(ws, { signal: invalidSignal }), 'pipeTo should reject'); |
There was a problem hiding this comment.
Should we test that this never calls any underlying source methods?
| .then(() => { | ||
| assert_equals(rs.events.length, 2, 'cancel should have been called'); | ||
| assert_equals(rs.events[0], 'cancel', 'first event should be cancel'); | ||
| assert_equals(rs.events[1].name, 'AbortError', 'the argument to cancel should be an AbortError'); |
There was a problem hiding this comment.
Maybe also test that its .constructor.name is DOMException.
Also check the constructor name of the AbortError is DOMException.
|
I will write tests for abort-after-completion. That was an important oversight. |
ricea
added a commit
to whatwg/streams
that referenced
this pull request
Oct 19, 2018
The reference implementation now supports the "signal" option to pipeTo(). It has diverged from the standard text, which will be updated separately. Tests are at web-platform-tests/wpt#13358.
Once a shutdown condition happens, aborting the signal should no longer do anything. Verify this works.
Use preventCancel, preventClose and preventAbort to keep the readable or writable open after the pipeTo finishes to verify that the abort doesn't close them.
domenic
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for aborting ReadableStream.prototype.pipeTo using an
AbortSignal.
Tests correspond to PR whatwg/streams#744.