docs: fix SSR Node bundle usage in docs #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Nov 27, 2024
| // Load SSR bundle | ||
| const indexModule = await serverAPI.environments.ssr.loadBundle('index'); | ||
| // Load Node bundle for SSR | ||
| const indexModule = await serverAPI.environments.node.loadBundle('index'); |
There was a problem hiding this comment.
I prefer to use environments.node instead of environments.ssr. @9aoy what do you think?
There was a problem hiding this comment.
Prefer environments.node. I will check other places where environments.ssr is used and correct it
9aoy
approved these changes
Nov 28, 2024
chenjiahan
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect usage of
ssrenvironment in the documentation. Updated to use the correct node bundle for SSR rendering. In this PR used same environment in doc which used inCreate SSR configuration.Related Links
https://rsbuild.dev/guide/advanced/ssr#custom-server
Checklist